In a previous PR, we introduced from_sdk_creds(...) to convert from aws_credential_types::Credentials to locally defined AwsCredential type. Now that we've converted the rest of the authentication to use the AWS SDK, we no longer need this conversion

will uncomment once PR is approved

This will panic if the conversion fails; instead, we should propagate an authentication error

nit: since we're not using the returned signature, I think this can call output rather than into_parts

Thanks Isabel! I tried switching to .output(), but ran into a borrow checker error when calling apply_to_request_http1x on line 291. I double-checked the method signature and saw that it needs an owned value which we get with .into_parts(), whereas .output() returns a reference.

The .into_parts() also matches what I saw in the two references we looked at (1, 2). Let me know if you had a different approach in mind!

ah I missed the reference vs. owned value distinction, feel free to leave as-is

sounds good, thanks!

ah I missed the reference vs. owned value distinction, feel free to leave as-is

This will ignore any failures that occur when converting the strings and proceed with authentication. This would likely cause the signature to be computed incorrectly, and the reported error might be confusing for users to parse. Instead, I suggest doing the following to propagate an error here:

let headers: Result<Vec<_>> = request
    .headers()
    .iter()
    .map(|(k, v)| {
        let v = v.to_str().map_err(|_| {
            Error::authentication_error(
                MECH_NAME,
                "Failed to convert header value to valid UTF-8",
            )
        })?;
        Ok((k.as_str(), v))
    })
    .collect();

This uses a handy iterator trick: if an iterator is mapped into Result values, you can collect it into a Result<Vec<_>> (or a Result of any collection type). That result will either contain Ok(Vec<_>) if all of the values were Ok, or an Err(_) containing the first error that was encountered.

We then need to return an error if needed using ? and turn the value back into an iterator, which is the type accepted by SignableRequest::new:

headers?.into_iter()

This should make what happened more clear if something goes wrong with the headers.